Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码规范：制品名字不应该带版本号 #42

Open
sinkcup opened this issue Sep 6, 2021 · 0 comments
Open

代码规范：制品名字不应该带版本号 #42

sinkcup opened this issue Sep 6, 2021 · 0 comments

Comments

@sinkcup
Copy link
Member

sinkcup commented Sep 6, 2021 •
edited
Loading

刚才合并了 #39 ，然后发现不对：制品名字不应该带版本号

以前我 review 的时候发现了这个问题，现在看 CI 跑通了，就大意了。

看来 lint 强制检查代码规范 需要增加这个检查

image

wecom-temp-0d61eb815460a467c4e85cdf193316bf
Hot-Rain1 pushed a commit to Hot-Rain1/coding-download-center that referenced this issue Sep 9, 2021
feat : coding#42 check package name should not have version
a401fcc
Hot-Rain1 added a commit to Hot-Rain1/coding-download-center that referenced this issue Sep 12, 2021
@Hot-Rain1
feat : coding#42 check package name should not have version
9e33012
sinkcup pushed a commit that referenced this issue Oct 12, 2021
@Hot-Rain1
ci: #42 package name should not contain version
c9101ab
sinkcup added a commit that referenced this issue Oct 27, 2021
@sinkcup
Revert "ci: #42 package name should not contain version"
c005167 
This reverts commit c9101ab.
sinkcup added a commit that referenced this issue Oct 27, 2021
@sinkcup
revert: #42 package name contain version
06fe49c 
This reverts commit c9101ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sinkcup