Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image parsing regex bug #97

Open
codicocodes opened this issue Jan 12, 2024 · 0 comments
Open

Fix image parsing regex bug #97

codicocodes opened this issue Jan 12, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@codicocodes
Copy link
Owner

it.skip('matches absolute github url with "-" in owner name', () => {
const md = "![fidget.nvim demo](https://github.com/j-hui/fidget.nvim/blob/media/gifs/fidget-demo-rust-analyzer.gif?raw=true)"
const output = "https://raw.githubusercontent.com/j-hui/fidget.nvim/media/gifs/fidget-demo-rust-analyzer.gif"
const media = run(md, "j-hui", "fidget.nvim", "main");
expect(media[0]).toEqual(output);
expect(media.length).toBe(1);
})

Make this test and all other tests pass, the image matching code is trash but at least we're starting to have some test coverage so we can refactor when appropriate

@codicocodes codicocodes added the help wanted Extra attention is needed label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant