Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Enhanced Validation for First Name, Last Name and short description during signup #631

Open
ksraj123 opened this issue Sep 29, 2020 · 1 comment
Open

[ENHANCEMENT] Enhanced Validation for First Name, Last Name and short description during signup #631

ksraj123 opened this issue Sep 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ksraj123
Copy link
Contributor

ksraj123 commented Sep 29, 2020 •
edited

Describe the enhancement you'd like

  • There is no validation in place for the first name and last name sections of the signup form. So the user could enter anything, even complete articles as their first name or last name.
    Screenshot from 2020-09-30 00-53-20
    Screenshot from 2020-09-30 01-00-32

  • short description has a lower bound on the number of characters but no upper bound.
    Screenshot from 2020-09-30 01-59-43

Describe approaches if you have thought of any
These fields should satisfy the following constraints

  • The first name could contain only one whitespace and up to 15 characters
  • The last name could not contain any whitespace and up to only 12 characters
  • Neither the first name nor last name could contain any special characters or numbers
  • Short Description can have up to 250 characters

HINT - Regex

Additional context
Good First Issue, Hacktoberfest
@ksraj123 ksraj123 added the enhancement New feature or request label Sep 29, 2020
@ksraj123 ksraj123 changed the title [ENHANCEMENT] Validation for First Name and Last Name during signup [ENHANCEMENT] Enhanced Validation for First Name, Last Name and short description during signup Sep 29, 2020
@ksraj123 ksraj123 mentioned this issue Sep 29, 2020
Open
DantrazTrev added a commit to DantrazTrev/social-platform-donut-frontend that referenced this issue Oct 4, 2020
@DantrazTrev
Added all the Form enhancements
416d5df 
For issue codeuino#630 codeuino#631 
Added regex based Phone Number Validation 
Added regex based Name Validation and Error messages
Updated the Validation of Description and it's Error message
@DantrazTrev DantrazTrev mentioned this issue Oct 4, 2020
Open
@jalajk24
Copy link

jalajk24 commented Apr 4, 2023

@ksraj123 can i work on this issue??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksraj123 @jalajk24