Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file leak when running in Docker #967

Closed
wants to merge 1 commit into from

Conversation

codetheweb
Copy link
Owner

@codetheweb codetheweb commented Aug 31, 2023

Closes #966.

  • I updated the changelog

@github-actions
Copy link

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-967 or codetheweb/muse:84ad6112dd3b09bb5ff050403327568ae8afc6c4.

Images are available for x86_64 and ARM64.

Latest commit: 84ad611

@ghost
Copy link

ghost commented Mar 7, 2024

is this in the masterbuild? I notice in unraid my ram usage just slowly keeps creeping up the longer I listen to the bot.

@codetheweb
Copy link
Owner Author

codetheweb commented Mar 8, 2024

This was superseded by #976. It looks like the issue should be fixed when running in Docker, but may not yet be fixed if you're running it manually from the repo. How do you run Muse?

@codetheweb codetheweb closed this Mar 8, 2024
@ghost
Copy link

ghost commented Mar 11, 2024

Its from the unraid docker. I will give it a few more tests when I have some time.

@FoxxMD
Copy link
Contributor

FoxxMD commented Mar 13, 2024

Unraid CA for muse is using the official codetheweb/muse docker image, just FYI.

As an aside, @GitGurky, this could be due to node's tendency to hoard ram even if its not used. If your unraid server has a ton of free ram and you have not limited it using Extra Parameters in the CA template for muse there is a possibility node is just hanging on to ram because there is more to spare. I don't have an article handy to back this up but I have encountered similar behavior in other apps I develop.

You can force node to try to stay within a specific total ram allotment by passing the node arg

node --max_old_space_size=NUMBER ...

where NUMBER is the megabytes of ram it should try to stay under. This should be compatible with passing to tsx as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Container Infinitely Grows
2 participants