Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSB embed editor does not properly highlight <script type="module"> #8259

Open
3 tasks done
markerikson opened this issue Jan 10, 2024 · 1 comment
Open
3 tasks done

Comments

@markerikson
Copy link

馃悰 bug report

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project
    adheres to.
  • I have searched the issue tracker for an issue that matches the one I want
    to file, without success.

Description of the problem

I just updated a Redux docs vanilla JS example sandbox to go from a plain <script> tag to a <script type="module">. Now, the embed editor no longer does any syntax highlighting for the JS code in that script tag:

image

The code highlights correctly in the full CSB editor:

image

How has this issue affected you? What are you trying to accomplish?

This is a bare basic example of Redux usage with vanilla JS, to illustrate the concepts.

Lack of syntax highlighting isn't a total breaking issue, but it's definitely annoying and makes it harder for Redux learners to read the code in this example.

To Reproduce

Link to sandbox: https://codesandbox.io/s/redux-fundamentals-core-example-lr7k1?from-embed=&file=/index.html

@JamesACS
Copy link
Contributor

Thank you for flagging this @markerikson - I've raised the issue with the team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants