Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are channels necessary? #276

Open
monfresh opened this issue Apr 10, 2021 · 3 comments
Open

Why are channels necessary? #276

monfresh opened this issue Apr 10, 2021 · 3 comments
Assignees

Comments

@monfresh
Copy link

I couldn't find a clear explanation of why CodeClimate has to keep adding versions of Rubocop to the channels. Is it not possible to install the version of Rubocop that is specified in the Gemfile.lock and then analyze the PR using that version? It seems like CodeClimate is always behind in terms of adding the latest version of Rubocop to the channels.

If I don't specify the channel option in the .codeclimate config, it looks like CodeClimate uses version 0.52 of Rubocop. Why such an old version?

@monfresh
Copy link
Author

Doing a quick search for alternatives in the GitHub Actions marketplace, I found reviewdog, and they offer the following options for setting the rubocop version, which sound very reasonable:

  • empty or omit: install latest version
  • gemfile: install version from Gemfile (Gemfile.lock should be presented, otherwise it will fallback to latest bundler version)
  • version (e.g. 0.90.0): install said version

What is different about Code Climate that prevents it from having the Rubocop integration be this user-friendly? Would it not be a win-win for both the Code Climate team to not have to keep track of Rubocop releases and remember to manually add a new version of Rubocop to the channels, and for your customers to be happier and not have to wait for a particular version to be added to the channel?

@klyonrad
Copy link

klyonrad commented Apr 19, 2021

channels are necessary because the codeclimate business does not prioritize appeasing the ruby dev ecosystem.

As I have written in an older comment I consider it the number one reason why I'd never advocate moving beyond the free plan for it.

The issue that you have written now is a

Duplicate of #93

@monfresh
Copy link
Author

Thanks @klyonrad. I didn't see that issue! Maybe the more people make noise, the more they'll listen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants