Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I.waitForURL() does not fail the test when its timeout happens #4346

Open
lewimuchiri opened this issue May 13, 2024 · 0 comments
Open

I.waitForURL() does not fail the test when its timeout happens #4346

lewimuchiri opened this issue May 13, 2024 · 0 comments

Comments

@lewimuchiri
Copy link

lewimuchiri commented May 13, 2024

What are you trying to achieve?

Wait for the page to navigate to a certain URL and fail the test if it doesn't navigate within the defined timeout

What do you get instead?

The test does not fail. Also, In the below source code, the log after I.waitForURL() is never printed. Where does it disappear to? The log that's printed is the one that's within the healer, HEALING A FAILED CLICK STEP:#fake-id. This is what is displayed on the logs after the test run:

Play around --
  Playground
   Given I want to test healers ""
   before waitForURL <--------------------------------------------- see here
    I say "HEALING A FAILED CLICK STEP:#fake-id" <----------------- and here
   HEALING A FAILED CLICK STEP:#fake-id  <------------------------- and here
    I wait for visible "#fake-id", 9
  × FAILED in 29095ms


-- FAILURES:

  1) Play around
       Playground:
     element (#fake-id) still not visible after 9 sec
locator.waitFor: Timeout 9000ms exceeded.
Call log:
  - waiting for locator('#fake-id').first() to be visible

  Error: element (#fake-id) still not visible after 9 sec
  locator.waitFor: Timeout 9000ms exceeded.
  Call log:

  Scenario Steps:
  - I.waitForURL("https://fake-url", {"timeout":10000,"waitUntil":"load"}) at .\tests\steps\playground.ts:21:5
  - I.say("before waitForURL") at .\tests\steps\playground.ts:20:5
  - I.amOnPage("https://github.com/codeceptjs/CodeceptJS/issues") at .\tests\steps\playground.ts:19:5

Provide test source code if related

# Playground.feature

Feature: Play around
  Scenario: Playground
    Given I want to test healers
// playground.ts

Given("I want to test healers", () => {
  I.amOnPage("https://github.com/codeceptjs/CodeceptJS/issues");
  I.say("before waitForURL");
  I.waitForURL("https://fake-url", {
    timeout: 10000,
    waitUntil: "load"
  });

  I.say("after waitForURL");
  I.click("#fake-id");
});
// heal.ts

const { heal, ai } = require("codeceptjs");

heal.addRecipe("waitForVisibleThenClick", {
  priority: 1,
  steps: [
    "click"
  ],
  fn: async ({ step }) => {
    const locator = step.args[0];

    return ({ I }) => {
      I.say("HEALING A FAILED CLICK STEP:" + locator);

      I.waitForVisible(locator, 9);
      I.click(locator);
    };
  },
});

Details

  • CodeceptJS version: 3.6.2
  • NodeJS Version: 20.12.2
  • Operating System: Windows 11
  • Helper: Playwright Helper
  • Configuration file:
require('./heal')

export const config: CodeceptJS.MainConfig = {
  output: './output',
  helpers: {
    Playwright: {
      url: "https://github.com/codeceptjs/CodeceptJS/issues",
      show: false,
      browser: 'chromium'
    }
  },
  gherkin: {
    features: ["./tests/**/features/Playground.feature"],
    steps: "./tests/**/steps/*.ts"
    // steps: ["./stock_take_service/steps/given.ts", "./stock_take_service/steps/when.ts", "./stock_take_service/steps/then.ts"]
  },
  include: {
    I: './steps_file',
  },
  plugins: {
    heal: {
      enabled: true
    }
  },
  name: 'playground'
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant