Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Accessibility -> Visual Effects -> "Always show scrollbars" : Settings window positioned too right, scrollbars are hidden #2222

Open
MisterTickle opened this issue Apr 29, 2024 · 4 comments
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@MisterTickle
Copy link

1. Bug Report:

BUG: When showing the Settings for ImprovedTube, it is rendered much too far across to the right. The browser's own scrollbar covers over any scrollbar which is on the right of the Settings windows. (Those are much too thin for me to use comfortably, I personally dislike the "tiny thin" styling which only expands to a thicker width after you've hovered on it, as you need a lot of dexterity which not everyone has to get there in the first place and raises accessibility issues - but that's a separate gripe. For now I'm just talking about the ability to see the scrollbars at all)
⚬ Browser: Chrome Version 124.0.6367.92 (Official Build) (64-bit).
HOW: Press the Settings icon. It's impossible to get to the scrollbars, or see that there are any.
⚬ It may be relevant that I use Windows Accessibility -> Visual Effects -> "Always show scrollbars", because I detest floating / disappearing scrollbars in general. In general it is not good to assume there will never be a scrollbar when positioning things, as you never know!
⚬ Then, un-maximise the Chrome window, so that it can be re-sized. Luckily, the Settings pane does not move. Now, the tiny scrollbars on the right side of the Settings pane are finally visible, and can be used, and I can get to the other options. (with a mouse wheel it is possible to scroll, only if you know there are things to scroll in advance, with a laptop, it's a lot harder depending on the configuration of trackpads etc.. None of this is as good as actually being able to see a scrollbar which is the visible indicator that you are not seeing all of the options and need to take action to get to what is not fitting on the screen.)
⚬ Are any *Browser console errors shown? Not around the time of clicking Settings, no.
⚬ ImprovedTube Version: 4.826

image
image

@MisterTickle MisterTickle added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Apr 29, 2024
@ImprovedTube ImprovedTube changed the title Settings window positioned too far to the right, scrollbars are hidden, impossible to scroll up/down settings Windows Accessibility -> Visual Effects -> "Always show scrollbars" : Settings window positioned too right, scrollbars are hidden Apr 29, 2024
@ImprovedTube
Copy link
Member

thank you! @MisterTickle.
We should also add full-tab version sooner than later.

Extension popups aren't very accessible as a whole. Now chrome also supports sidebars. (Which stay until closed)

Yes, i think thin scrollbars are just a visual indicator mostly.
When you move the mouse over it goes wider. Might only work when coming from the right side, does it?

@MisterTickle
Copy link
Author

MisterTickle commented Apr 29, 2024

Thankyou very much for accepting this issue!

The scrollbars do go from "thin" to "slightly less thin" when I mouse over them, yes. But they are far too thin initially, IMHO, so it's unnecessarily difficult to mouse over the exact spot to make them go fatter, if that makes sense. :)

I have lots and lots of screen height available. Would you consider allowing the Settings pane to take up more vertical height, to reduce the need for scrolling anyway, even (for some screens) remove the need completely? I don't see why it couldn't take up the browser's full height, and then just let it scroll as before.

@raszpl
Copy link
Contributor

raszpl commented Apr 29, 2024

Yes, i think thin scrollbars are just a visual indicator mostly. When you move the mouse over it goes wider. Might only work when coming from the right side, does it?

yes, its very thin and that enlarging effect is glitchy and weird.
There is plenty of space for proper normal width scrollbar.

@ImprovedTube ImprovedTube added Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) and removed Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) labels May 9, 2024
@ImprovedTube
Copy link
Member

Would you consider allowing the Settings pane to take up more vertical height, to reduce the need for scrolling anyway, even (for some screens) remove the need completely? I don't see why it couldn't take up the browser's full height

Maximum allowed is 600²px. Added an option to use it as a sidebar (still invisible), which chrome supports only since 2023 and requires to move Manifest3, which we are forced to move to by June anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: No status
Development

No branches or pull requests

3 participants