Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DISCARD ALL inside default_transaction_use_follower_reads #124150

Open
dikshant opened this issue May 14, 2024 · 0 comments
Open

Allow DISCARD ALL inside default_transaction_use_follower_reads #124150

dikshant opened this issue May 14, 2024 · 0 comments
Assignees
@michae2
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@dikshant
Copy link

dikshant commented May 14, 2024 •
edited

#120158 made it so that DISCARD ALL can no longer be run with the session variable default_transaction_use_follower_reads which makes the transaction read only.

Unfortunately this breaks npgsql where it issues DISCARD ALL. This is by design and explained here:
npgsql/npgsql#2920

We should add a opt in cluster/session setting that allows discard all to be run in such scenarios.

Jira issue: CRDB-38729
@dikshant dikshant added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team labels May 14, 2024
@michae2 michae2 self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michae2 michae2

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Active
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dikshant @michae2