Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: add correctness validators to all cdc roachtests #124148

Open
rharding6373 opened this issue May 14, 2024 · 1 comment
Open

changefeedccl: add correctness validators to all cdc roachtests #124148

rharding6373 opened this issue May 14, 2024 · 1 comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented May 14, 2024 •
edited by exalate-issue-sync bot

Ordering and at least once delivery validators should be added to all existing CDC roachtests to improve test coverage.

Jira issue: CRDB-38727

Epic CRDB-38755
@rharding6373 rharding6373 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture T-cdc labels May 14, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented May 14, 2024

cc @cockroachdb/cdc

@andyyang890 andyyang890 mentioned this issue May 15, 2024
Merged
craig bot pushed a commit that referenced this issue May 17, 2024
@andyyang890
Merge #124195
d8073b5 
124195: roachtest: add order validation to CDC Kafka roachtests r=rharding6373 a=andyyang890

This patch adds order validation to CDC Kafka roachtests so that we
can build more confidence in our ordering guarantees. It can be enabled
for a roachtest either by directly setting the `validateOrder` flag on a
`kafkaManager` before creating consumers, or indirectly by setting the
`validateOrder` flag on `kafkaFeedArgs` for tests that use `cdcTester`.

Informs #124148

Release note: None

Co-authored-by: Andy Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rharding6373