Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering away Youtube Shorts? #8

Closed
krusty4president opened this issue Dec 11, 2023 · 16 comments · Fixed by #22
Closed

Filtering away Youtube Shorts? #8

krusty4president opened this issue Dec 11, 2023 · 16 comments · Fixed by #22
Labels
enhancement New feature or request

Comments

@krusty4president
Copy link

Hi. I am using it with my freshrss installation. Is it possible to filter out Youtube shorts with this extension?

@cn-tools cn-tools added the enhancement New feature or request label Dec 13, 2023
@cn-tools
Copy link
Owner

this plug in is changing the url of the added feed only yet and doesn't do any interaction with feed entries.

but i'll take a look if i can fulfill your wish.

@krusty4president
Copy link
Author

That would be so helpful both to me and the community. Unfortunately som channels just bloat the content with so many YT Shorts.

@krusty4president krusty4president changed the title Question on YoutubeChannel2RssFeed extension Filtering away Youtube Shorts? Dec 13, 2023
@colinstu12
Copy link

Agreed, that would be useful

@cn-tools
Copy link
Owner

cn-tools commented May 6, 2024

Hello @krusty4president and @colinstu12

a few seconds ago i checked in a alpha version to detect youtube shorts.

Please test it and i'm happy to read your feedback.

@colinstu12
Copy link

Thanks @cn-tools
Was this addon required previously to import YT channels? I was already able to just put the channel's URL into the add feed screen without the need of addon nor this API docker for [YouTube-operational-API].

@cn-tools
Copy link
Owner

cn-tools commented May 6, 2024

@colinstu12

There are other addons availabe to change a YT channel url into a feed URL. Whithout any of this addons it's not able to do this, as i know.

If you want to add only YT urls for playlists, channels, user you don't need the third party url 'YouTube-operational-API'. With the third-party url it is possible to process YT handles like 'https://youtube.com/@youtube'

Additional with 'YouTube-operational-API' you can detect YT shorts and therefor you could mark them as read or will block them.

@i300220
Copy link

i300220 commented May 9, 2024

Shorts are now marked as read, per the extension configuration. Works perfectly well. Thank you so much @cn-tools !

Does not log though. Might be me, not the extension. All that is logged here from FreshRss is the SimplePie messages. Found nothing in the GUI nor in the config files to enable logging with Minz_Log

@cn-tools
Copy link
Owner

THX @i300220 for the positive answer!

Do you see any LOG message on LOG page inside the settings of FreshRSS?

@i300220
Copy link

i300220 commented May 12, 2024

Do you see any LOG message on LOG page inside the settings of FreshRSS?

Capture d’écran du 2024-05-12 12-20-41

I do, but none related to this extension.

Thanks!

@i300220
Copy link

i300220 commented May 17, 2024

Arrgh! They're now making 20 second videos that aren't technically shorts e.g.

https://www.youtube.com/watch?v=lox2ZemF3HI -> 200
https://www.youtube.com/shorts/lox2ZemF3HI -> 303 redirect to https://www.youtube.com/watch?v=lox2ZemF3HI

https://yt.lemnoslife.com/videos?part=short&id=lox2ZemF3HI

{
    "kind": "youtube#videoListResponse",
    "etag": "NotImplemented",
    "items": [
        {
            "kind": "youtube#video",
            "etag": "NotImplemented",
            "id": "lox2ZemF3HI",
            "short": {
                "available": false
            }
        }
    ]
}

@cn-tools
Copy link
Owner

grrrrrr 🫣

i will have a look, but i think this should be checked and fixed (if iths possible) by the development team of the third-party software

@i300220
Copy link

i300220 commented May 23, 2024

Makes sense. I had a look at the 3rd party code.

This would determine the duration of the same video as above in seconds.

https://yt.lemnoslife.com/videos?part=contentDetails&id=lox2ZemF3HI

{
    "kind": "youtube#videoListResponse",
    "etag": "NotImplemented",
    "items": [
        {
            "kind": "youtube#video",
            "etag": "NotImplemented",
            "id": "lox2ZemF3HI",
            "contentDetails": {
                "duration": 20
            }
        }
    ]
}

One could check the duration and if it's less than 60 seconds, decide a short is therefore available whether there is one or not.

Here, you kill 2 birds with 1 stone:

https://yt.lemnoslife.com/videos?part=contentDetails,short&id=lox2ZemF3HI

{
    "kind": "youtube#videoListResponse",
    "etag": "NotImplemented",
    "items": [
        {
            "kind": "youtube#video",
            "etag": "NotImplemented",
            "id": "lox2ZemF3HI",
            "contentDetails": {
                "duration": 20
            },
            "short": {
                "available": false
            }
        }
    ]
}

If you prefer I submit it to the 3rd party, let me know.

Patch attached, currently under evaluation:
extension.diff.gz

Best!

@cn-tools
Copy link
Owner

Your shot on two birds looks like a really good way and base. 👍

I will have a look in the next few days.
Thx for the DIFF file!

Best!

@cn-tools
Copy link
Owner

@i300220 could you test the branch YT-shorts, please?

i added a new setting to define a duration. All shorter videos will be declared as 'short' too yet

@i300220
Copy link

i300220 commented May 28, 2024

Hi,

Gladly.

Installed. Duration set to 5 minutes to be certain to intercept some files. Will reset to 60 seconds if all goes well. Shorts by duration are very uncommon.

Thanks a lot!

@cn-tools cn-tools linked a pull request May 29, 2024 that will close this issue
@i300220
Copy link

i300220 commented Jun 1, 2024

Tested with shorts, shorts by duration and regular videos and, everything is as expected. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants