Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default priority of localization for dynamic scheduling is 1000(the highest), which is not flexible #779

Open
abstractmj opened this issue Jan 12, 2024 · 2 comments
Labels
kind/bug Something isn't working kind/feature New feature or request

Comments

@abstractmj
Copy link
Contributor

when migrate third-party workload(like openkruise https://openkruise.io/zh/docs/user-manuals/advancedstatefulset) to clusternet, we may need to implements certain controller logic to override the default localization. the default priority 1000 make this difficult;

@abstractmj abstractmj added the kind/bug Something isn't working label Jan 12, 2024
@dixudx dixudx added the kind/feature New feature or request label Jan 12, 2024
@dixudx
Copy link
Member

dixudx commented Jan 12, 2024

@abstractmj The default localization with highest priority 1000 is created based on the scheduling results. This object is only created when the scheduling strategy is Dividing. This design helps make sure the clusternet-created localization object for changing replicas can work as desired.

For your case, I think we may introduce a new field in Localization to indicate this localization could override clusternet-created localizations with the same priority.

@abstractmj
Copy link
Contributor Author

sounds reasonable

@abstractmj The default localization with highest priority 1000 is created based on the scheduling results. This object is only created when the scheduling strategy is Dividing. This design helps make sure the clusternet-created localization object for changing replicas can work as desired.

For your case, I think we may introduce a new field in Localization to indicate this localization could override clusternet-created localizations with the same priority.

sounds reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants