-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to process predictor error response ? #684
Labels
kind/feature
New feature or request
Comments
|
I'd prefer using method 1 to return 0 replica, which is friendly to current scheduling framework and implementations. By adding a new flag in struct
If so, it will be better to taint the cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added:
If predict http request failed , return an error and cancel scheduling , like this:
https://github.com/clusternet/clusternet/blob/main/pkg/scheduler/framework/plugins/predictor/predictor.go#L128
One cluster predictor failure resulted in a subscription scheduling failure, which is inappropriate.
Why is this needed:
The task is to find a better way to solve this problem.
If method 1 is used, cluster which replicas is 0 will still in binding cluster, and cannot be removed, either it needs to be removed during the merge process, or there might be other ways to address this.
And if method 2, drop the cluster from available cluster list when one feed predict failed even this subs have many feeds, It is a radical approach when there are only a few child clusters.
The text was updated successfully, but these errors were encountered: