the user's custom localization overwrite by the framework-generated localization

[zhenkuang]

What would you like to be added:

We hope that the priority of user-customized localization is higher than the priority of the framework-generated localization.

Why is this needed:

The default priority of localization in the framework is 1000. If the priority of a custom localization is also 1000, the priority of localization will be determined by the create time of the localization. But the framework's Localization will be rebuilt, which will result in the user's custom localization being overwritten.

clusternet/pkg/controllermanager/deployer/localizer/localizer.go

Lines 434 to 440 in 3e69b51

	sort.SliceStable(locs, func(i, j int) bool {
	if locs[i].Spec.Priority == locs[j].Spec.Priority {
	return locs[i].CreationTimestamp.Second() < locs[j].CreationTimestamp.Second()
	}
	return locs[i].Spec.Priority < locs[j].Spec.Priority
	})

[dixudx]

We hope that the priority of user-customized localization is higher than the priority of the framework-generated localization.

The default priority of localization in the framework is 1000. If the priority of a custom localization is also 1000

The framework will help generate a system-defined Localization that purely override replicas based on the FeedInventory. We set the highest priority for this object to make sure we will get this desired replicas in the final. And these system-defined Localization objects will only be created when the scheduling strategy is set to Dividing.

For other fields except replicas, of course you CAN set your Localization objects with highest priority 1000. That won't make any conflicts or changes unless you want to make changes on replicas as well. If so, there will be a risk that will lead to chaos. But if you do want to change the replicas, you can create such a Localization object with highest priority 1000 after a while.

[zhenkuang]

We hope that the priority of user-customized localization is higher than the priority of the framework-generated localization.

The default priority of localization in the framework is 1000. If the priority of a custom localization is also 1000

The framework will help generate a system-defined Localization that purely override replicas based on the FeedInventory. We set the highest priority for this object to make sure we will get this desired replicas in the final. And these system-defined Localization objects will only be created when the scheduling strategy is set to Dividing.

For other fields except replicas, of course you CAN set your Localization objects with highest priority 1000. That won't make any conflicts or changes unless you want to make changes on replicas as well. If so, there will be a risk that will lead to chaos. But if you do want to change the replicas, you can create such a Localization object with highest priority 1000 after a while.

But I think that the Localization created by the user does not affect the operation of the entire framework. Can we consider providing a feature gate to support this setting?

[dixudx]

But I think that the Localization created by the user does not affect the operation of the entire framework.

Please submit a PR on this. Let's see how it will work.

[zhenkuang]

But I think that the Localization created by the user does not affect the operation of the entire framework.

Please submit a PR on this. Let's see how it will work.

ok, I will submit a version rencently