Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: kitexcall command for sending json generic requests #1331

Closed
felix021 opened this issue Apr 18, 2024 · 5 comments
Closed
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@felix021
Copy link
Contributor

felix021 commented Apr 18, 2024

Please help implement a command line tool for sending json generic requests to Kitex Servers.

Suggests features:

  • Support Thrift/Protobuf Payload
  • Support TTHeader/Framed (also TTHeader/Framed) Transport
  • Support specifying frequently used client options (client.WithHostPorts, client.WithRPCTimeout, etc.)
  • Support metainfo (headers), both transient keys and persistent keys, and listing backward keys in the response to output.
  • Accept request data from command line arg or a local file
  • Support both human readable (by default) or Parsable output response (call status, rpc response, etc., json format preferred), making it better for script-based tools)

If you are interested in implementing this feature, please kindly prepare a detailed tech plan and reply with your lark id for us.

@felix021 felix021 added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 18, 2024
@felix021
Copy link
Contributor Author

felix021 commented Apr 18, 2024

You can also take a look at grpcurl, which is of similar purpose.

Note: currently Kitex does not have builtin support of reflection server, so users have to manually specify the IDL. But we've plan for this and once it's implemented, this feature can then be integrated into kitexcall.

@Zzhiter
Copy link
Contributor

Zzhiter commented Apr 19, 2024

Can you assign it to me please? I want to try it. The technical plan will be sent to you later.

@felix021
Copy link
Contributor Author

Can you assign it to me please? I want to try it. The technical plan will be sent to you later.

Please reply with your lark account

@Zzhiter
Copy link
Contributor

Zzhiter commented Apr 19, 2024

Can you assign it to me please? I want to try it. The technical plan will be sent to you later.

Please reply with your lark account

OK, thanks. I am in the Cloudwego Lark Group, I have sent you a friend request.
Or my account:
https://www.feishu.cn/invitation/page/add_contact/?token=5b7gab67-dddd-42a4-93d5-cd2441b59833&unique_id=lSWTsPYII_yaxHM80y-SNw==

@felix021
Copy link
Contributor Author

Implemented in kitex-contrib/kitexcall#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

2 participants