Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bthrift]method WriteByte(buf []byte, value int8) int should have signature WriteByte(byte) error #1139

Open
cherishman2005 opened this issue Oct 1, 2023 · 2 comments
Assignees

Comments

@cherishman2005
Copy link

Describe the bug

  • Makefile
GOVET        := $(GO) vet

vet-case:
        ${GOVET} ./...

  • make result
protocol/bthrift/binary.go:108:23: method WriteByte(buf []byte, value int8) int should have signature WriteByte(byte) error
protocol/bthrift/binary.go:413:23: method ReadByte(buf []byte) (value int8, length int, err error) should have signature ReadByte() (byte, error)
protocol/bthrift/interface.go:47:2: method WriteByte(buf []byte, value int8) int should have signature WriteByte(byte) error
protocol/bthrift/interface.go:92:2: method ReadByte(buf []byte) (value int8, length int, err error) should have signature ReadByte() (byte, error)
make: *** [Makefile:106: vet-case] Error 2

To Reproduce

vet-case:
        ${GOVET} ./...
  1. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Kitex version:

master branch

Environment:

GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB="*"
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://goproxy.yy.com"
GOROOT="/usr/local/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.3"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build202129420=/tmp/go-build -gno-record-gcc-switches"
@YangruiEmma
Copy link
Member

which kitex version you use?

@YangruiEmma
Copy link
Member

you'd better check the compile error code and provide more detailed info, it should not happen

@YangruiEmma YangruiEmma self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants