-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaintenanceWindowLambdaParameters Payload incorrect validation. #2004
Comments
Interesting. Thanks for highlighting this issue. One solution would be using Fn::Base64 although that would likely break for encoded strings larger than 4096. Perhaps a validator like this? (untested)
|
@blade2005 have you had a chance to review or try the above? |
@markpeek somehow I missed this notification. The code looks like it would work. I've not tried it. I'm no longer working on that project anymore. I'm not sure if the 4096 constraint is on base64 encoded data or the decoded format. |
Per the documents here https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ssm-maintenancewindowtask-maintenancewindowlambdaparameters.html#cfn-ssm-maintenancewindowtask-maintenancewindowlambdaparameters-payload
"Although Type is listed as "String" for this property, the payload content must be formatted as a Base64-encoded binary data object."
https://github.com/cloudtools/troposphere/blob/main/troposphere/ssm.py#L194 validates that it's proper JSON but the expected value should be base64 encoded JSON string.
The text was updated successfully, but these errors were encountered: