Data duplication inside VmAllocationPolicy implementations #107
Labels
Comments
manoelcampos
added a commit
that referenced
this issue
Jun 16, 2017
--------------------------- Added multiple PE Lists into the Host implementations and added a Host.setPeStatus to manage the PEs into each list. The Pe status must not be changed directly, only using the Host method. It is used multiple lists instead of only one, which can be filtered to find the PEs according to a given Status, because there are lots of access to methods which returns PEs with specific status. For large scale simulations, filtering a global List of PEs all the time drastically impacts performance. The previous version was really using a single List and after profiling, proved to hamper performance.
manoelcampos
changed the title
manoelcampos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VmAllocationPolicyimplementations use lots ofMapsto associate the number of free PEs for each Host andListsof these PEs which are free.After CloudSim Plus, all this information can be got from the direct association between classes. For instance, it's possible to make a call such as
cloudlet.getVm().getHost().getDatacenter()which allow navigating between the entire logical and physical infrastructure to get any information you want.However, these Maps and Lists are used yet in some classes. They are just duplicating data which can be got from the source objects. Further, the use of Maps reduces the performance of allocation of Hosts to VMs for large simulation scenarios.
Unnecessary Maps and Lists should be removed and the data they were storing must be got directly from the source object. For instance, the List of free PEs must be got directly from the Host.
The text was updated successfully, but these errors were encountered: