Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-source): Make issues table incremental based on updated field #17780

Open
erezrokah opened this issue Apr 24, 2024 · 2 comments
Open

Comments

@erezrokah
Copy link
Contributor

Looks like we can sort issues by updated date ascending and filter by time:
https://github.com/google/go-github/blob/8d4be0b2cf2b8242a0b7e3777232cd0058ae535f/github/issues.go#L188

This should allow making the issues table incremental.

Went over other tables, didn't find another candidate

@duncanmapes
Copy link

This would be great. Assuming github_action_runs are already incremental?

@erezrokah
Copy link
Contributor Author

erezrokah commented May 8, 2024

Assuming github_action_runs are already incremental?

We tried to make it incremental but since we can't sort the results it's not possible (we can't use a value to filter + sort, e.g. create_at then get all runs from a specific date).
However you can filter runs using a table option:

spec:
  access_token: "${GITHUB_PERSONAL_ACCESS_TOKEN}"
  table_options:
    github_workflow_runs:
      created_since: '3 days ago'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants