Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: For GCS plugin tests, the bucket name needs to be set in file #17612

Open
2 tasks done
shubham-padia opened this issue Apr 12, 2024 · 1 comment
Open
2 tasks done

Comments

@shubham-padia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

GCS needs to have globally unique names, so when running tests in the GCS destination plugin, I can't run the tests on the bucket name mentioned in client_test.go.

Expected Behavior

To fix this, we should allow the bucket name to be set via a .env with the current bucket name as the default.

CloudQuery (redacted) config

Steps To Reproduce

CloudQuery (redacted) logs

CloudQuery version

Additional Context

Raised as followup to a comment raised in #17602

Pull request (optional)

  • I can submit a pull request
@erezrokah
Copy link
Contributor

To fix this, we should allow the bucket name to be set via a .env with the current bucket name as the default.

No need for an .env in other tests we read it using os.GetEnv, e.g.

ProjectID: os.Getenv("BIGQUERY_PROJECT_ID"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants