Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update golangci-lint config not to use deprecated run.skip-dirs option (replaced with issues.exclude-dirs) #17455

Open
5 tasks
candiduslynx opened this issue Apr 2, 2024 · 1 comment
Open
5 tasks

ci: Update golangci-lint config not to use deprecated run.skip-dirs option (replaced with issues.exclude-dirs) #17455

candiduslynx opened this issue Apr 2, 2024 · 1 comment
Labels
area/ci good-first-issue size/s

Comments

@candiduslynx
Copy link
Contributor

candiduslynx commented Apr 2, 2024 •
edited

We can see the following message running make lint in out plugin dirs with the latest golangci-lint:

WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.

This is not a priority for now, but should be outlined for the future.

Tasks
Beta Give feedback
@erezrokah
Copy link
Contributor

Example line to update

cloudquery/cli/.golangci.yml

Line 4 in a10fb7f

skip-dirs:

@dorian6255 dorian6255 mentioned this issue May 9, 2024
Merged
kodiakhq bot pushed a commit that referenced this issue May 9, 2024
@dorian6255
chore: Replacing deprecated run.skip-dirs for issues.exclude-dirs in …
6a22399 
…golanci.yml (#17916)

#### Summary

This PR resolve the issue #17455  => it removes the deprecated run.skipdir from .golangci.yml 

I used the documentation for golangci-lint here : https://golangci-lint.run/usage/configuration/#issues-configuration

#### Changes

there was only 2 .golangci.yml that needed changes (out of 4) : 
- the one in the cli folder 
- the one in the plugins folder (destination + source)


I did not change theses 2 : 
- plugin-sdk did not have the run.skipdir directive.
- codegen did not have any .golangci.yml file.

#### Testing method 

I tested  with golangci-lint before and after my modification : 
**Before**:
![before](https://github.com/cloudquery/cloudquery/assets/16516886/9b710643-d812-4753-a363-f61bb4f549cd)
**After:**
![after](https://github.com/cloudquery/cloudquery/assets/16516886/aaa4e511-1129-44a2-a5a9-ea6d22ae33d8)


This is my first contribution, I hope I did everything well,
Have a good day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci good-first-issue size/s
Projects
Framework
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@candiduslynx @erezrokah