Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CQ Summary Data to Custom Message Type #17118

Open
bbernays opened this issue Mar 11, 2024 · 3 comments
Open

Move CQ Summary Data to Custom Message Type #17118

bbernays opened this issue Mar 11, 2024 · 3 comments
Labels
area/plugin-sdk/go priority/p2 Low priority awaits more user feedback

Comments

@bbernays
Copy link
Collaborator

Currently the CLI sends a single insert message and destination that need to add more data have to filter on the table name.

#17117

The cleaner and more scalable way of implementing this is to create a custom message type for this rather than having a specific if statement in the main write function

@yevgenypats
Copy link
Member

do we really need a sync summary to be implemented in every destination though? or is it already there?

@bbernays
Copy link
Collaborator Author

Yes, every destination should be able to store the summary of the sync. We do not need to implement a custom message type if we are alright using the table name to add custom information (when it is necessary)

@erezrokah erezrokah added priority/p2 Low priority awaits more user feedback area/plugin-sdk/go labels Mar 12, 2024
@erezrokah
Copy link
Contributor

I marked this as low priority. We have it working in a single destination but the table name we use for sync summary is hard coded and coupled with the CLI's code. We can make it generic to all destinations via a designated protocol message if we need to add it to more destinations

@cq-bot cq-bot removed the needs-area label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-sdk/go priority/p2 Low priority awaits more user feedback
Projects
Status: No status
Development

No branches or pull requests

4 participants