Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make the org field in the GitHub spec be optional if app_auth is used. #16821

Open
1 task
alfredgamulo opened this issue Feb 22, 2024 · 0 comments
Open
1 task

Comments

@alfredgamulo
Copy link

Which problem is this feature request solving?

There's a redundancy in the GitHub configuration spec when app_auth is used. App auth implicitly has a 1-1 mapping between the app installation and access to an org so it is not necessary to specify the org field.

Describe the solution you'd like

Add logic somewhere at

if len(s.Orgs) == 0 && len(s.Repos) == 0 {
to consider the useage of app_auth

Pull request (optional)

  • I can submit a pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

2 participants