Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform Provider v5 Support #93

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Terraform Provider v5 Support #93

merged 9 commits into from
Aug 2, 2023

Conversation

milldr
Copy link
Sponsor Member

@milldr milldr commented Jul 24, 2023 •
edited by Nuru

This may be the final PR for this module. This module offers no value beyond the s3-bucket module and the terraform-aws-route53-alias module, so Cloud Posse is phasing out support for this redundant module. However, this PR should leave this module in a workable state until archival.

what

  • Terraform v5 updates
  • Support for new S3 bucket requirements
  • Rebuilt .github config
  • Apply tflint requirements
make init
make github/init
make readme

why

  • Updates to requirements for CI checks
  • Set bucket ownership and grants instead of public-read ACL to satisfy new S3 requirements

references

Closes Related PRs

Closes Related Issues

@milldr milldr requested review from a team as code owners July 24, 2023 22:53
@milldr milldr requested review from srhopkins and joe-niland and removed request for a team July 24, 2023 22:53
bridgecrew[bot]
bridgecrew bot reviewed Jul 24, 2023
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@milldr
Copy link
Sponsor Member Author

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Sponsor Member Author

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Sponsor Member Author

milldr commented Jul 24, 2023

/terratest

@milldr
Copy link
Sponsor Member Author

milldr commented Jul 24, 2023

/terratest

Nuru
Nuru requested changes Jul 25, 2023
View reviewed changes
Copy link
Sponsor

@Nuru Nuru left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert to pass-through to terraform-aws-s3-bucket so we can archive this module. s3-bucket should already have all the necessary features, and if not, add them there. LMK if it is too much work.

Update: it is, in fact, too much work.

examples/complete/versions.tf Outdated Show resolved Hide resolved
@milldr
Copy link
Sponsor Member Author

milldr commented Jul 25, 2023

Convert to pass-through to terraform-aws-s3-bucket so we can archive this module. s3-bucket should already have all the necessary features, and if not, add them there. LMK if it is too much work.

We decided that we will leave this as a final PR for the module, and redirect users to use the s3-bucket module instead. See the README and linked module in this PR description

@milldr
Copy link
Sponsor Member Author

milldr commented Jul 25, 2023

/terratest

@milldr milldr added the major Breaking changes (or first stable release) label Jul 25, 2023
@milldr
Copy link
Sponsor Member Author

milldr commented Jul 25, 2023

Labeled as a major release to call attention to final PR

@milldr milldr requested a review from Nuru July 25, 2023 19:43
@Nuru Nuru added minor New features that do not break anything and removed major Breaking changes (or first stable release) labels Aug 2, 2023
@Nuru
Copy link
Sponsor

Nuru commented Aug 2, 2023

/terratest

@Nuru Nuru enabled auto-merge (squash) August 2, 2023 06:20
@Nuru Nuru merged commit 760c346 into main Aug 2, 2023
10 checks passed
@Nuru Nuru deleted the s3_support branch August 2, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew left review comments

@Nuru Nuru Nuru approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
2 participants
@milldr @Nuru