/terratest

I believe I fixed the failures reported by the CI. :)

/terratest

🙃 Or not.
I did the mistake of running the make script as first step, let me fix that.

/terratest

Not sure what is failing.

Is it because the example is in ./examples/simple instead of ./examples/complete?

If yes, is renaming this in scope for this PR? 😅 I have no problem doing it, takes me 1 minute, I'm jsut wondering.

@esolitos yeah it looks like this module is so old it wasn't following where we put our primary example path (which is ancient) and therefore our newer CI pipes are failing as they expect that path. I'd move simple to complete and let's give it another run 👍

/terratest

Ah I think we need a versions.tf file for examples/complete like we have here: https://github.com/cloudposse/terraform-aws-transit-gateway/blob/main/examples/complete/versions.tf

It may be that we need more than that too... We'll see what the test harness does. This is an old module that hasn't seen love in a long while... so you picked a good one 😁

I did update the examples/complete with some additional love'n'care. 😄

/terratest

Haha I didn't realize there isn't even a test/src directory... @esolitos if we want this to pass our standard tests we would need to go all the way towards adding Terratest to this repo like in https://github.com/cloudposse/terraform-aws-transit-gateway/tree/main/test OR if I should just pull in Cloud Posse folks and see if they can get around to reviving this module from what you've already done.

💥 This pull request now has conflicts. Could you fix it @esolitos? 🙏

We still don't have terratests on this repo, so no use in trying to run them. I may take a crack at adding them at some point this week or next if I have the time. Thanks for the patience @esolitos!

💥 This pull request now has conflicts. Could you fix it @esolitos? 🙏

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.