Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD #29

Open
osterman opened this issue Sep 12, 2018 · 2 comments · Fixed by cloudposse/build-harness#109
Open

Fix CI/CD #29

osterman opened this issue Sep 12, 2018 · 2 comments · Fixed by cloudposse/build-harness#109
Assignees

Comments

@osterman
Copy link
Member

osterman commented Sep 12, 2018

what

why

  • I don't know

references

@osterman
Copy link
Member Author

CI/CD is still broken. While the root cause was fixed, looks like the code is no longer vetted =)

https://travis-ci.org/cloudposse/github-authorized-keys/builds/402672514#L863

Open a new PR to fix the code so it passes CI/CD and results in a successful build.

@alebabai
Copy link

alebabai commented Oct 2, 2018

@osterman issue still exists in go/vet target approach.
So we couldn't use constructions like $(GO) vet -v package1/file.go package2/file1.go like in example with
find . ! -path "*/vendor/*" ! -path "*/.glide/*" -type f -name '*.go' | xargs $(GO) tool vet -v, because it require that files to be from the same package.
So code vetting require all project structure with dependencies. Most common use case that i found is

$(GO) vet -v ./...

It recursively vetting project code and ignores folders started with . and _.
I think we should switch to this approach in build harness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants