Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update matchit dependency #363

Closed

Conversation

gytis-ivaskevicius
Copy link

@gytis-ivaskevicius gytis-ivaskevicius commented Jul 30, 2023

Updated matchit dependency. This PR resolves #362

Tested and it is working, ready to be merged

@@ -1,7 +1,7 @@
use std::{collections::HashMap, future::Future, rc::Rc};

use futures_util::future::LocalBoxFuture;
use matchit::{Match, Node};
use matchit::{Match, Router as Node};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node has been renamed in https://github.com/ibraheemdev/matchit/releases/tag/v0.5.0
I had to perform this rename since Router conflicts with the struct defined in line 45

@gytis-ivaskevicius
Copy link
Author

Also, I am not sure how the release cycle works here, when can I expect to see v0.0.18 released?

@9oelM
Copy link

9oelM commented Oct 19, 2023

Would love to see getting this merged. any updates on this? v0.4.6 was released on Feb 1, 2022...

@9oelM
Copy link

9oelM commented Oct 19, 2023

@gytis-ivaskevicius the tests are failing though

@hxzhao527
Copy link

any plan to merge this?

new version change the behavior of Catch-all Parameters

version doc
0.4.6 Catch-all parameters start with * and match everything including the trailing slash.
latest Catch-all parameters start with * and match everything after the /.

trim_start_matches("/"); in handler is too weird.

@9oelM
Copy link

9oelM commented Dec 8, 2023

@hxzhao527
I just ended up forking it myself for my own use. It works great already. I recommend you do the same

@9oelM
Copy link

9oelM commented Dec 8, 2023

But matchit really needs to be updated, otherwise I see no hope in workers-rs. The dependency is too old already and it doesn't work as expected

@kflansburg
Copy link
Member

Done in #450

@kflansburg kflansburg closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants