-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appetite for refactoring to be SANS-IO (including time?) #391
Comments
thomaseizinger
changed the title
Appetite for refactoring to be sans-io (including time?)
Appetite for refactoring to be SANS-IO (including time?)
Jan 24, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This library is basically SANS-IO except for calls to
Instant::now
. I was wondering what the appetite is for changing that?encapsulate
anddecapsulate
should likely take annow: Instant
parameter to accurately reflect timestamps of last received packets.update_timers
should also take anow: Instant
parameter.update_timers
can save the providednow
timestamp as local state and all other functions can compute durations etc based on that timestamp. Thus, accuracy of that depends entirely on the user in how often they callupdate_timers
.We might want to consider renaming
update_timers
to something likehandle_timeout
orupdate_now
.The text was updated successfully, but these errors were encountered: