Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector: make next-sibling work over atoms #219

Open
vemv opened this issue Nov 15, 2023 · 5 comments
Open

Inspector: make next-sibling work over atoms #219

vemv opened this issue Nov 15, 2023 · 5 comments
Labels
enhancement Improvement to an existing feature

Comments

@vemv
Copy link
Member

vemv commented Nov 15, 2023

It currently only works over sequential things - not atoms wrapping those.

@bbatsov bbatsov added the enhancement Improvement to an existing feature label Feb 21, 2024
@alexander-yakushev
Copy link
Member

Does this mean navigating over a list of atoms, or an atom of list?

@vemv
Copy link
Member Author

vemv commented Apr 29, 2024

atom of list

@alexander-yakushev
Copy link
Member

I just checked, this already works with the current sibling implementation on master.

@vemv
Copy link
Member Author

vemv commented Apr 29, 2024

Awesome! Then it would be a matter of making sure there are specific tests for it

@alexander-yakushev
Copy link
Member

alexander-yakushev commented May 30, 2024

Just in case – this is not fully fixed yet. It works if the list inside atom was bigger than page size, so we rendered a collapsed value that the user first clicked, then clicked one of the items, then started prev/nexting it. But if we rendered an expanded list on the Atom view, and the user clicked from there, then prev/next doesn't work. Fixing this requires rethinking path construction yet again. This is in my backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants