Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-g doesn't abort add-require #296

Open
Malabarba opened this issue Feb 16, 2016 · 3 comments
Open

C-g doesn't abort add-require #296

Malabarba opened this issue Feb 16, 2016 · 3 comments

Comments

@Malabarba
Copy link
Member

The same is probably true of other commands. If I invoke ar, start typing a namespace name, and then change my mind, C-g doesn't behave as expected.

I would expect it to either (1) go back to what I had before the command started or (2) abort the command and leave the ns form as it is now.

Instead, when I hit C-g, it leaves the ns form as it is now and then continues with the command (which means that it cleans up and evaluates the ns form). Evaluating the ns form is particularly problematic because I'm guaranteed to have an unfinished namespace name in there.

@magnars
Copy link
Contributor

magnars commented Feb 16, 2016

Good point. This has annoyed me as well. Maybe we should ditch our yasnippet dependency and add a simpler placeholder minor-mode.

@expez
Copy link
Member

expez commented Aug 7, 2019

@bbatsov I don't think we need the stalebot in this project or for refactor-nrepl.

I don't see any value in closing issues just because they're old. They're still relevant and if someone wants to help out they now have a list of issues to take on.

@expez
Copy link
Member

expez commented Aug 7, 2019

@MalloZup Wait, you just took it upon yourself to update every issue with a staleness report? If none of the other maintainers asked you to do this, could you please have the bot clean up after itself (in the refactor-nrepl repo too, please) and delete all the comments it made? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants