Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifests to the published releases #292

Open
maxgio92 opened this issue Apr 17, 2023 · 6 comments · May be fixed by #309
Open

Add manifests to the published releases #292

maxgio92 opened this issue Apr 17, 2023 · 6 comments · May be fixed by #309

Comments

@maxgio92
Copy link
Contributor

maxgio92 commented Apr 17, 2023

Feature

Release both binaries and operator manifests (CRDs, webhook configurations, controller, RBAC, etc.).

Motivation

Consumers might need or want to install Kamaji from bare manifests, without the requirement of using Helm.

Additional context

A practical scenario can be kamajictl which can install a specific version of Kamaji, by downloading and applying its released manifests.

Goreleaser could then be leveraged to bundle in the release archive binaries, manifests, signatures, etc. (e.g. https://github.com/fluxcd/kustomize-controller/blob/main/.goreleaser.yaml#L6).

dierbei added a commit to dierbei/kamaji that referenced this issue Jun 21, 2023
@dierbei
Copy link

dierbei commented Jun 21, 2023

I try to use go releaser to build the program, this is my rendering, does it meet the requirements?

image

dierbei added a commit to dierbei/kamaji that referenced this issue Jun 21, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 21, 2023
@dierbei
Copy link

dierbei commented Jun 21, 2023

I changed the architecture of the program build.

image

@dierbei dierbei linked a pull request Jun 21, 2023 that will close this issue
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jun 22, 2023
@prometherion prometherion added this to the v0.3.1 milestone Jun 30, 2023
dierbei added a commit to dierbei/kamaji that referenced this issue Jul 1, 2023
@maxgio92
Copy link
Contributor Author

maxgio92 commented Jul 4, 2023

Thanks @dierbei. The goal here is to release also bare manifests of the Kamaji operator, in order to allow consumers to install Kamaji without using Helm, by applying the manifests bundle.

Moreover, the manifests bundle could be either split between CRD and controllers or it could contain both (all-in-one).

@dierbei
Copy link

dierbei commented Jul 5, 2023

@maxgio92 Thanks for your answer.

If I understand correctly, it is necessary to add crd, controller and other related yaml files when releasing, right? Pack them in a separate tarball file.

In this way, you can use kubectl to install directly.

@prometherion
Copy link
Member

I'd like to thank @dierbei for the patience here, the issue wasn't clear from the beginning and iterated over multiple times to address our requirements.

@maxgio92 I'd say we could remove this from the 0.3.1 milestone so we can easily release Kamaji and try to solve this in a more comfortable way.

@prometherion prometherion removed this from the v0.3.1 milestone Jul 7, 2023
@maxgio92 maxgio92 changed the title Release manifests with goreleaser Release manifests Jul 7, 2023
@maxgio92 maxgio92 changed the title Release manifests Add manifests to the published releases Jul 7, 2023
@maxgio92
Copy link
Contributor Author

maxgio92 commented Jul 7, 2023

Agree @prometherion.
I've just reworked the issue title and content to better explain the goal and the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants