Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the kamaji-etcd helm chart as dependancy of the kamaji chart #238

Open
bsctl opened this issue Jan 5, 2023 · 4 comments
Open

Set the kamaji-etcd helm chart as dependancy of the kamaji chart #238

bsctl opened this issue Jan 5, 2023 · 4 comments
Assignees
Labels
helm Changes addresses in the Helm chart needs-discussion

Comments

@bsctl
Copy link
Member

bsctl commented Jan 5, 2023

Currently, the kamaji Helm Chart is optionally installing its own datastore based on etcd. At same time, we developed the kamaji-etcd Helm Chart to provide a multi-tenant datastore for Kamaji based on etcd . To avoid duplication in maintenance of the charts, it would be useful to remove the native etcd datastore option in Kamaji Helm Chart and use the kamaji-etcd instead as dependancy sub-chart.

@bsctl bsctl self-assigned this Jan 5, 2023
@prometherion prometherion added helm Changes addresses in the Helm chart good first issue Good for newcomers labels Jul 3, 2023
@bsctl bsctl added needs-discussion and removed good first issue Good for newcomers labels Aug 27, 2023
@jwitko
Copy link
Contributor

jwitko commented Jan 5, 2024

This would be really useful. I just got confused by this trying Kamaji for the first time. The helm chart is also more configurable than the kamaji chart installation. For example I cannot add annotations to the serviceAccount for etcd in the kamaji chart.

Edit: It's even worse. The ETCD statefulset is hard-coded to use default serviceAccount.

@prometherion
Copy link
Member

The ETCD statefulset is hard-coded to use default serviceAccount

Although this should be discussed in the kamaji-etcd chart, there's a rationale behind that, mostly related to the fact etcd is not expecting to interact with the Kubernetes API Server: the actions performed there, such as backups, are triggere with a temporary ServiceAccount deployed thanks to Helm hooks (source).

@prometherion
Copy link
Member

@MathiasPius I remember your efforts in the Kamaji Etcd chart, wondering if you could help us with this task

@MathiasPius
Copy link

@prometherion I appreciate the opportunity, but I'm afraid I don't have very much insight into how Kamaji uses etcd under the hood, nor exactly how helm sub charts function, so I'd be very worried about causing loss of data for existing users of the charts.

I think the task is best left to someone else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm Changes addresses in the Helm chart needs-discussion
Projects
None yet
Development

No branches or pull requests

4 participants