Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement String.prototype.replaceAll #638

Open
classilla opened this issue Mar 7, 2021 · 1 comment
Open

Implement String.prototype.replaceAll #638

classilla opened this issue Mar 7, 2021 · 1 comment

Comments

@classilla
Copy link
Owner

This actually could be useful for some of the other work we're doing. A simple-minded version would take str_replace in jsstr.cpp and make one that loops around. It should check that if it got a RegExp, that the global flag were set. This wouldn't be super fast but it would be a working first pass.

https://bugzilla.mozilla.org/show_bug.cgi?id=1540021
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll

@classilla
Copy link
Owner Author

js::str_flat_replace_string will replace all occurrences. We can just use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant