Fix doubled key input on Windows, Fixes ckampfe/russ#22 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows all key events would be taken as input including keyup leading to double inputs. Fixes ckampfe#22 ckampfe#22
|
Note, this change has only been tested on Windows. Needs to be tested on other OSes |
|
@sobharrison thank you very much for your contribution. I've tested this on MacOS and it appears to work the same with no regression. I will take your word for it that it works on Windows, as I do not use Russ on Windows myself. Unfortunately I recently introduced a large refactoring to how Russ handles input, and so this PR conflicts with that. I was able to pull your changes in and commited them here 4c3e259 Again, thank you for the contribution, and I hope this is a satisfactory outcome for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows all key events would be taken as input including keyup leading to double inputs.
Fixes #22
#22