Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

Add config file for customizing the layout #39

Open
ghost opened this issue Feb 12, 2020 · 13 comments
Open

Add config file for customizing the layout #39

ghost opened this issue Feb 12, 2020 · 13 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 12, 2020

As i've mentioned in the previous issue i would be nice if displaying the graph is just an optional feature.

The reason i picked ytop for my defaul taks manager is because of its simpliciy compared to top, htop and glances.

@ghost ghost changed the title Make graps optional. Make graphs optional. Feb 12, 2020
@cjbassi
Copy link
Owner

cjbassi commented Feb 12, 2020

Do you mean just the CPU and memory graphs? So I see a couple ways of implementing this:

  1. have an option to toggle whether to show the graphs
  2. add a config file to specify which widgets to show

The second option would be more work but would also be more general

@ghost
Copy link
Author

ghost commented Feb 13, 2020

I think both options are vaild

A toggle to switch on and off the graps and a modular approach for the rest of the components.

For example ytop -c (CPU) -m (memory) -t (temperature) -g (graphs). Would be the ideal set up for me. Only the information I want to see in a space without clutter and any other distractions.

@cjbassi
Copy link
Owner

cjbassi commented Feb 14, 2020

I don't think specifying the widgets on the command line would work, unless we have users add the layout too, but that might get a little convoluted. So I think the best way to do this is just to have a config file where users specify which widgets they want and the layout for them.

@ghost
Copy link
Author

ghost commented Feb 14, 2020

I agree with you.

@cjbassi cjbassi changed the title Make graphs optional. Add config file for customizing the layout Feb 15, 2020
@cjbassi
Copy link
Owner

cjbassi commented Feb 15, 2020

@ghost
Copy link
Author

ghost commented Feb 16, 2020

What about the graphs ?

@cjbassi
Copy link
Owner

cjbassi commented Feb 16, 2020

You should be able to remove the graphs using the config file. Does that work for you or were you thinking something else?

@ghost
Copy link
Author

ghost commented Feb 16, 2020

Well I mentioned at the start of the topic the reason i enjoy using ytop is because of its simplicity. The issue with the graphs is that they add distortion to that. I was thinking that by your mentioning a configuration file there would be the possibility to disable them there.

@cjbassi
Copy link
Owner

cjbassi commented Feb 16, 2020

Yeah exactly, you should be able to disable them in the config file.

@cjbassi cjbassi added the enhancement New feature or request label Feb 17, 2020
@ghost
Copy link
Author

ghost commented Feb 17, 2020

Thanks

@ghost ghost closed this as completed Feb 17, 2020
@cjbassi
Copy link
Owner

cjbassi commented Feb 17, 2020

You're welcome, but I'm going to reopen this since it still needs to be implemented :)

@cjbassi cjbassi reopened this Feb 17, 2020
@ghost
Copy link
Author

ghost commented Feb 23, 2020

is it implemented in gotop ? because i dont have the config file present

@cjbassi
Copy link
Owner

cjbassi commented Feb 23, 2020

No, it's not implemented in gotop. But there is a fork of gotop that has a config file implementation and I linked it above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant