Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trex to run on x86 systems with more than 240 threads and sub-numa #1120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make trex to run on x86 systems with more than 240 threads and sub-numa #1120

wants to merge 1 commit into from

Conversation

Civil
Copy link
Contributor

@Civil Civil commented Mar 18, 2024

clustering

  • Fix dpdk_setup_ports numa detection code - it now support sub-numa clustering
  • Remove artificial limitation on 63 max cores in dpdk_setup_ports
  • Change RTE_MAX_LCORE in build options for DPDK
  • Update trex_defs to unify ppc and x86 and also make arg string bigger
  • Change BP_MAX_CORES to 256 (not sure why it is not dynamically determined...)

Fixes #1119

@Civil
Make trex to run on x86 systems with more than 240 threads and sub-numa
eb463ae 
clustering

 * Fix dpdk_setup_ports numa detection code - it now support sub-numa
   clustering
 * Remove artificial limitation on 63 max cores in dpdk_setup_ports
 * Change RTE_MAX_LCORE in build options for DPDK
 * Update trex_defs to unify ppc and x86 and also make arg string bigger
 * Change BP_MAX_CORES to 256 (not sure why it is not dynamically
   determined...)
@Civil
Copy link
Contributor Author

Civil commented Mar 18, 2024

There is alternative approach - for my setup it would be enough to still keep 128 cores, and dpdk support custom mapping (you can map your real thread ids to virtual ones and that way keep it below 128).

But that would require more work on refactoring.

I can try to do that and also move static allocation for BP_MAX_CORES to dynamic one but later.

@trex-bot
Copy link

Checked SHA: eb463ae
Status: SUCCESS ✔️
Link to job: http://81.218.86.50:8080/job/trex_build/829/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpdk_setup_ports.py gets NUMA topology wrong with Sub-NUMA clustering enabled
2 participants
@Civil @trex-bot