cyhy_mongo_ansible_provisioner may start cyhy-commander service too soon

[dav3r]

🐛 Bug Report

In certain cases (such as spinning up a brand new environment), the terraform module cyhy_mongo_ansible_provisioner will attempt to start up the cyhy-commander service before all of the port and vulnerability scanner instances are ready.

To Reproduce

Steps to reproduce the behavior:

• Terminate all EC2 instances in a workspace via the AWS console
• terraform apply -var-file=<PRODUCTION-VARIABLES-FILE>

Expected behavior

The cyhy_mongo_ansible_provisioner should not attempt to start up the cyhy-commander service until all of the portscan and vulnscan instances have been provisioned and had their DNS records created.

Any helpful log output

Sample output from /var/log/cyhy/commander.log at startup when the scanner instances are not ready:

2019-05-30 19:22:50,532 DEBUG cyhy_commander.commander - Checking remotes for completed jobs to download and process
2019-05-30 19:22:50,859 WARNING cyhy_commander.commander - Unable to get listing of "runner/done" on portscan1
2019-05-30 19:22:51,067 WARNING cyhy_commander.commander - Unable to get listing of "runner/done" on portscan2
2019-05-30 19:22:51,289 WARNING cyhy_commander.commander - Unable to get listing of "runner/done" on portscan3
2019-05-30 19:22:51,591 WARNING cyhy_commander.commander - Unable to get listing of "runner/done" on portscan4