Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall modules using the required versions #1088

Open
1 task
james-garriss opened this issue May 6, 2024 · 0 comments
Open
1 task

Uninstall modules using the required versions #1088

james-garriss opened this issue May 6, 2024 · 0 comments
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@james-garriss
Copy link
Collaborator

馃挕 Summary

What is the work, as a high-level summary? There are two parts to this issue:

  1. There is a script (UninstallModules.ps1) that uninstalls the modules that ScubaGear installs. This script hardcodes the set of modules to uninstall, and this list is out of sync with those that are installed. This script should be updated to use the modules listed in the required versions file (RequiredVersions.ps1).
  2. This script only uninstalls modules, but that is not everything that ScubaGear installs. It should be improved so that it also uninstalls OPA and ScubaGear itself. Details can be found in the new and improved documentation.

Motivation and context

Why does this work belong in this project?

  • Violating the DRY principle is a code smell.
  • When the code is out of sync, it will fail to uninstall all of the modules, leaving unwanted debris on the user's computer.
  • There should be one simple way for users to uninstall everything that ScubaGear installs.

Implementation notes

Please provide details for implementation:

  • Remove hardcoding.
  • Reference the required versions file.
  • Uninstall those modules.
  • Uninstall OPA.
  • Uninstall ScubaGear
  • Test, test, test.
  • Test with both types of installation (install from PSGallery and download from GitHub).

Acceptance criteria

How do we know when this work is done?

  • The uninstall modules script uninstalls everything!
@james-garriss james-garriss added the enhancement This issue or pull request will add new or improve existing functionality label May 6, 2024
@schrolla schrolla added this to the Iceberg milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants