-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observe: Support -f
and --first
at the same time
#959
Comments
@pchaigno I would like to contribute to this, could you provide me with some code pointers |
Hi @sladyn98 thanks for the interest! Currently, in Hubble "follow mode" the server will never close the gRPC stream. If I understand correctly, the proposition is to add support for "an exit condition" to follow mode (in the issue description the condition being once one flow is returned, expressed by The first step would be to remove the safe guards we have around the current incompatibility of "follow" and "first", see here for Hubble server and here for the client. Then, the server must implement the feature, probably moving this check before the Finally, the feature will need some test (see this one for example) and validation from @pchaigno (please add him as a reviewer!). |
I find the combination of Perhaps rather than overloading the combination, we can think of a new flag that would make it clear that we're going to follow the output until something is found. |
Supporting those two flags at the same time would allow us to write for example:
That would trigger the collection of a sysdump only as soon as a specific kind of packet drop is noticed.
In the meantime, it's possible to achieve the same with:
The text was updated successfully, but these errors were encountered: