Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Configurable prometheus labels #789

Open
djfinnoy opened this issue Feb 14, 2024 · 0 comments
Open

Feature request: Configurable prometheus labels #789

djfinnoy opened this issue Feb 14, 2024 · 0 comments
Assignees

Comments

@djfinnoy
Copy link

We use Victoria Metrics instead of Prometheus. As a consequence, the Hide prometheus app filter in Hubble UI does not work out of the box. I had a look at the code, and noticed that the way Hubble UI identifies prometheus is via the app: prometheus label. I applied this label to our Victoria Metrics scraper, and the filter works.

This feels like a bit of a hack. My proposed solution is that the key value label pair for identitfying a metrics scraper becomes configurable via environment variables, or a configuration file. If no value is defined, hubble ui should default to the modern label standards for prometheus: app.kubernetes.io/name: prometheus, and fall-back to app: prometheus as a last resort for people who are running Prometheus through old manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants