Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Preload an option #10

Open
e7mac opened this issue Dec 26, 2020 · 2 comments
Open

Make Preload an option #10

e7mac opened this issue Dec 26, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@e7mac
Copy link

e7mac commented Dec 26, 2020

Sometimes, when there are lots of MIDI Files displayed on a page, preloading them all might be undesirable. Could it be possible to make an option preload=False in the <midi-player> ?
@cifkao
Copy link
Owner

cifkao commented Dec 26, 2020

Good idea! Maybe something like preload="none" as in the <audio> element. Possibly preload="bare" to load only the MIDI file and not the sound font.

There should also be a clear indication in the UI (different icon?) that the player is loading, as opposed to a disabled or error state. Which is a good idea anyway.

@cifkao cifkao added the enhancement New feature or request label Dec 26, 2020
@cifkao cifkao changed the title Feature Request: Make Preload an option Make Preload an option Dec 26, 2020
@e7mac
Copy link
Author

e7mac commented Dec 27, 2020

Ideas for the loading indicator: a "shimmer" on the whole player/timeline slider, or a progress bar on the timeline slider

@cifkao cifkao mentioned this issue Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e7mac @cifkao