-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up on focus event helper function #9
Comments
Tests to investigate:
These tests failed for us when running on Firefox or phantomjs…
…the focus part was the issue Test failure example, focus not firing when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rwjblue there is one other point to chat about at some point too, the focus method in the existing test helpers has an issue with Firefox and focus on window or not. I was able to resolve that in this library as I added test running via Chrome, Firefox on Travis as well.
See…
https://github.com/cibernox/ember-native-dom-helpers/blob/master/addon-test-support/helpers.js#L11-L31
vs.
https://github.com/emberjs/ember.js/blob/7819409b7b6559e9fc0300a29e66a16356fb67a7/packages/ember-testing/lib/events.js#L8-L27
The text was updated successfully, but these errors were encountered: