Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unicode instaed of codepage 0 switching #3

Closed
yne opened this issue Dec 7, 2017 · 10 comments
Closed

use unicode instaed of codepage 0 switching #3

yne opened this issue Dec 7, 2017 · 10 comments

Comments

@yne
Copy link

yne commented Dec 7, 2017

As described here chubin/wttr.in#151 (comment) the rate.sx use codepage switching escape command to draw it boxes instead of simply using the unicode equivalent.

Could you draw the rate.sx table layout using unicode in both application ?

@chubin
Copy link
Owner

chubin commented Dec 8, 2017

I hope that after the issue is fixed, the problem reported by @davep in twitter will disappear also
https://twitter.com/davepdotorg/status/939085767070113792

@davep
Copy link

davep commented Dec 8, 2017

Excellent. I'll remove rate-sx-unboxify once that's done.

@yne
Copy link
Author

yne commented Dec 8, 2017

Can't wait to look at my eth/btc from my vita :D

@chubin
Copy link
Owner

chubin commented Dec 8, 2017

@yne Hope you will see it soon :) (do you want to see etc/btc pair? because crypto pairs are not yet supported, only crypto/non-crypto at the moment). Do you have something like a status line in your terminal on Vita by the way? Do you use there tmux or something like that?

@chubin
Copy link
Owner

chubin commented Dec 8, 2017

Please test, it should work now

@davep
Copy link

davep commented Dec 8, 2017

I appear to still be seeing the codepage switching approach.

@chubin
Copy link
Owner

chubin commented Dec 8, 2017

Could you please try gbp.rate.sx?

@davep
Copy link

davep commented Dec 8, 2017

Okay, yeah, that looks good with gbp.sate.sx; showing just great inside GNU Emacs.

screen shot 2017-12-08 at 19 36 04

When this is the default I'll tweak the code.

@chubin
Copy link
Owner

chubin commented Dec 8, 2017

Perfect! Now it should work for rate.sx also (it was a caching issue). Now the cache on the endpoint was updated, so it should work for all queries.

What seems a little bit strange to me that the timestamp and the frame are of different colours. They should be the same actually. Interesting.

@yne Now it will work on Vita also (I hope)

davep added a commit to davep/rate-sx.el that referenced this issue Dec 8, 2017
@yne
Copy link
Author

yne commented Dec 10, 2017

It's working, I had to add support for the SGR "2" (used to darken the box) and it look fine now, thanks for the fix.
out

I don't need crypto/crypto pairing charts. Thanks ;)

@yne yne closed this as completed Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants