Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: conventional commits #82

Open
moon2l opened this issue Nov 3, 2020 · 4 comments
Open

Feature request: conventional commits #82

moon2l opened this issue Nov 3, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@moon2l
Copy link

moon2l commented Nov 3, 2020

https://www.conventionalcommits.org/
https://github.com/brigand/glint

@moon2l moon2l changed the title conventional commits feature is good idea Feature request: conventional commits Nov 3, 2020
@chriswalz chriswalz added the enhancement New feature or request label Nov 3, 2020
@sheldonhull
Copy link

sheldonhull commented Oct 4, 2021

I was just thinking of building something but didn't want to add more fragmentation here.
Bit would be a great place for supporting an option with conventional commits.

For a nice example of what I've found: https://github.com/SKalt/git-cc

@chriswalz would you be up for a contribution to add bit cc or equivalent type of helper command that could prompt through a conventional commit layout and support a config file like that tool being used to autofill scopes/defaults if it exists?

Would much rather see extensibility with Bit vs adding more tooling here.

Also if so, any quick 101 bullet list on where the best place is for contributing something similar would be?

@chriswalz
Copy link
Owner

chriswalz commented Oct 5, 2021

I think would be nice! Do you think could outline the usage of commands here (e.g. `bit cc <> does A, bit cc does B, etc..)

See my notes for getting started adding a command here
#87 (comment)

Regarding a config file I've been avoid that and leaning on ENV variables for now. We could hard code a config as a first pass and then find a way to best handle config file solution once the bit cc command solution is mostly setup

@sheldonhull
Copy link

Sweet!
The config would have to be an optional thing, but would probably be required because the conventional commit scopes are defined typically for a repo in it.
I was thinking of actually building the scope list from the git recent history so might be possible to do that, but would still be useful to have a predefined list for team members.

For the first go round, it could just be the standard allowed commits by the Angular Conventional Commit format and that would be a good iteration one to see how it works out.

Command draft

bit cc and a promptui with add option to pick type. You can use this image from the git-cc repo I linked above for a visual of what that might look like (not exact but a good visual!)

conventional commit

Here's another from git-cz

resources

@chriswalz
Copy link
Owner

Looks good to me. I think you should go for it! If you get stuck I'll be happy to help out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants