Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support of gitmoji for commit messages #40

Open
gensjaak opened this issue Oct 13, 2020 · 6 comments
Open

Feature: Add support of gitmoji for commit messages #40

gensjaak opened this issue Oct 13, 2020 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@gensjaak
Copy link

Make bit save to propose directly emojis for commit messages.

https://github.com/carloscuesta/gitmoji
https://marketplace.visualstudio.com/items?itemName=Vtrois.gitmoji-vscode

@chriswalz chriswalz added the enhancement New feature or request label Oct 13, 2020
@chriswalz
Copy link
Owner

Can you go into more detail. How would this look when using bit save

@chriswalz
Copy link
Owner

@gensjaak

@gensjaak
Copy link
Author

We could have in this list commit -am -with-emoji "...

Screenshot 2020-10-21 at 11 50 42 AM

...and it would have a sublist with emojis like this in the CLI
Screenshot 2020-10-21 at 11 53 55 AM

And the final output will be something like this
bit commit -am "🚀 Version v1.0.1 deployed!"

@chriswalz chriswalz added this to the v0.9.5 milestone Oct 28, 2020
@gensjaak gensjaak changed the title Add support of gitmoji for commit messages Feature: Add support of gitmoji for commit messages Oct 28, 2020
@chriswalz
Copy link
Owner

@gensjaak could you provide me a list of all the gitmoji options. I was hoping to see a list somewhere on the github repo but didn't see one.

Here's a PoC. Note bit gitmoji is used but I'm still considering the interface example you had provided
image

chriswalz added a commit that referenced this issue Oct 29, 2020
@gensjaak
Copy link
Author

@chriswalz you can find a perfect list here from carloscuesta repos
List of emojis: https://github.com/carloscuesta/gitmoji/blob/master/src/data/gitmojis.json

chriswalz added a commit that referenced this issue Oct 29, 2020
chriswalz added a commit that referenced this issue Oct 30, 2020
chriswalz added a commit that referenced this issue Nov 1, 2020
chriswalz added a commit that referenced this issue Nov 3, 2020
❤️

fixes #40

 add gitmoji list

 minor edit

 Improve structure / format of the code.
chriswalz added a commit that referenced this issue Nov 3, 2020
❤️

fixes #40

 add gitmoji list

 minor edit

 Improve structure / format of the code.
chriswalz added a commit that referenced this issue Nov 13, 2020
@chriswalz chriswalz reopened this Nov 13, 2020
@chriswalz
Copy link
Owner

@gensjaak I merge a pre-alpha version for gitmoji bit gitmojiI It's not very elegant to use since you select a description and then bit does a find and replace to get the respective emoji.

The reason I set it up this way is because go-prompt has a bug related to emoji as seen here: c-bata/go-prompt#209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants