Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcie_fuzz address argument handling #2155

Closed
loren-atredis opened this issue Apr 30, 2024 · 1 comment · Fixed by #2180
Closed

pcie_fuzz address argument handling #2155

loren-atredis opened this issue Apr 30, 2024 · 1 comment · Fixed by #2180
Assignees

Comments

@loren-atredis
Copy link

Hi, looks like there is an issue if you run pcie_fuzz.py with the address argument just as it is laid out in the docs:

# chipsec_main.py -i -m tools.vmm.pcie_fuzz -a 0 1f 0
...
[*] Running module: chipsec.modules.tools.vmm.pcie_fuzz
[*] Module arguments (3):
['0, '1f', '0']
[x][ =======================================================================
[x][ Module: PCIe device fuzzer (pass-through devices)
[x][ =======================================================================
[*] About to fuzz the following PCIe devices..
BDF     | VID:DID   | Vendor                       | Device
-------------------------------------------------------------------------
ERROR: Exception occurred during chipsec.modules.tools.vmm.pcie_fuzz.run(): 'not enough values to unpack (expected 6, got 5)'

This is because a 5 long tuple is created then unpacked to 6 length tuple and the error is thrown in print_pci_devices:

pcie_devices.append((_bus, _dev, _fun, 0, 0))

you can just add another zero to tuple to get rid of the error but I dunno if that breaks anything later:

pcie_devices.append((_bus, _dev, _fun, 0, 0, 0))
@npmitche
Copy link
Member

Thanks for the issue report. Looks like this was the only one that was missed when we updated print_pci_devices to include the RID. See #2180 for the fix.

@npmitche npmitche self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants