Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make a new release. #2774

Open
3ldar opened this issue Oct 2, 2022 · 7 comments
Open

Can you make a new release. #2774

3ldar opened this issue Oct 2, 2022 · 7 comments

Comments

@3ldar
Copy link

3ldar commented Oct 2, 2022

Hi,
I am currently using cheerio 1.0.0-rc12 and it was fine until one of other libraries we use forcing us to use "moduleResolution" : "node16" or newer. ('nodenext'). When we change this setting in tsconfig we started to have this error :

node_modules/cheerio/lib/esm/static.d.ts:2:42 - error TS2307: Cannot find module '.' or its corresponding type declarations.

2 import type { CheerioAPI, Cheerio } from '.';
                                           ~~~

It is possible to fix it by setting skipLibCheck to false or manually editing the d.ts file and replace '.' with ./index.js. I can see it is already fixed in your source file. So can you please make a new release to reflect that fix?

@meriturva
Copy link

Also here we are waiting for the final version with ESM Module support.
Any ETA?

Thanks.
Diego

@tobiasmuehl
Copy link

It is possible to fix it by setting skipLibCheck to false

needs to be set to true

@michaelfaith
Copy link

Would really appreciate a new release. From the bit that I've used it, the library is a great step forward. But we definitely need it to work with esm

@virtuallyunknown
Copy link

I am facing the same issue working in a monorepository using TypeScript 5.1.6 and cheerio 1.0.0-rc.12. This kinda screws me up because I'm forced to use skipLibCheck even across packages that don't use cheerio or import anything from it, I am not exactly sure why.

Come on guys, it's 2023. Proper ESM support should be a thing for any library.

@benasher44
Copy link

I'm not sure how this "Can you make a new release." issue became the one about TypeScript NodeNext support, but it would be really great to see this supported for the next 1.0 release. Maybe a maintainer can rename this ticket, so it doesn't get overlooked? @fb55

@benasher44
Copy link

@fb55 would you be open to accepting a PR for a fix?

@benasher44
Copy link

Oh I see. It's because this issue was fixed already in #3251, but there hasn't been a release since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants