-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression report displays exceptions inconsistently #858
Comments
Please share a reliable project/ config combination to reproduce this with. |
Done, updated in the issue description. Please see whether that's sufficient to reproduce. |
Looks good, thank you @Lmh-java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered at checkstyle/checkstyle#14791 (comment)
Regression report displays exceptions inconsistently.
Sometimes there is a full stacktrace for an exception:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8039a13_2024203306/reports/diff/elasticsearch/index.html#A139
Sometimes there is only a line of the exception name:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8039a13_2024203306/reports/diff/elasticsearch/index.html#A1
Both these two cases came from the same report generation:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8039a13_2024203306/reports/diff/index.html
To reproduce
Diff Regression config: https://gist.githubusercontent.com/Lmh-java/95ba8a3850cf6d670b2d65262531fb35/raw/7f17357bf8ec422286181c2d470ed578f8da485d/magic-number-config.xml
project lists: use the default (or only the following line for bare minimum)
groovy diff.groovy --localGitRepo [location of checkstyle project] --baseBranch [branch name without fix] --patchBranch [branch name with fix] --config magic-number-config.xml --listOfProjects test.properties -xm -Dcheckstyle.failsOnError=false --allowExcludes
Some analysis
After investigation, this difference presents before the results are sent to
patch-diff-report-tool
to compare. This difference is presented incheckstyle-result.xml
. For example:This means, when the checkstyle report is generated, this difference is already there. I also noticed that the single line stacktrace has


(\n) at the very end. This might be the cause of the incorrect termination of the line.The text was updated successfully, but these errors were encountered: