pagemap-cache: handle short reads #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
pagemap-cache-fix
branch
3 times, most recently
from
472a662
to
f5789e3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rst0git
force-pushed
the
pagemap-cache-fix
branch
from
f5789e3
to
c1c50de
Compare
rst0git
force-pushed
the
pagemap-cache-fix
branch
2 times, most recently
from
e7043b0
to
6737b5e
Compare
Is this error expected? |
avagin
reviewed
May 28, 2024
avagin
reviewed
May 28, 2024
|
Overall, it looks good to me. Thanks. |
It is possible for pread() to return fewer number of bytes than requested. In such case, we need to repeat the read operation with appropriate offset. Signed-off-by: Andrei Vagin <[email protected]> Signed-off-by: Radostin Stoyanov <[email protected]>
This commit adds a `--preload-libfault` option to ZDTM's run command. This option runs CRIU with LD_PRELOAD to intercept libc functions such as pread(). This method allows to simulate special cases, for example, when a successful call to pread() transfers fewer bytes than requested. Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
pagemap-cache-fix
branch
from
6737b5e
to
1e07c20
Compare
I was able to replicate this error on Ubuntu but not in Fedora. It looks like the reason for the error is because the repository is under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for
pread()to return fewer number of bytes than requested. In such case, we need to repeat the read operation with appropriate offset.Fixes: #2365