-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better handle 502 errors when merging PRs #739
Labels
bug
Something isn't working
Comments
Why do we raise ApiCallException for some errors but not others? kodiak/bot/kodiak/pull_request.py Lines 262 to 268 in b6b543d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When Kodiak starts merging a PR, it enters a loop, polling until the PR is ready to merge. If Kodiak makes a GitHub API request and encounters an error, it will eject from this loop, ignoring the PR and moving on to the next PR in queue.
This is problematic behavior as it can trigger extra updates to PRs. We should gracefully retry on recoverable errors.
Here's where we check for an error:
kodiak/bot/kodiak/queries/__init__.py
Lines 876 to 880 in afd6e59
We should audit all of our API requests to ensure we gracefully handle errors.
The text was updated successfully, but these errors were encountered: